-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed pyparsing limit #1022
removed pyparsing limit #1022
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1022 +/- ##
=======================================
Coverage 96.27% 96.27%
=======================================
Files 40 40
Lines 9357 9357
Branches 1103 1103
=======================================
Hits 9008 9008
Misses 205 205
Partials 144 144 ☔ View full report in Codecov by Sentry. |
The constraint on pyparsing is correct. |
Thanks for clarifying that. I guess I was just being hopefull that it could be removed as it causes a few incompatibles in downstream packages so naturally I would be happy to help if I can. |
@shimwell I don't understand what you want say here. Are you claiming that CQ works as-is with pyparsing 2.1.8? What is the incompatibility you are referring to? |
Sorry I got confused with my > and < signs. while trying to figure out why I can't install in my conda environment. Please ignore |
@shimwell Can you give examples of which downstream packages the pinned version causes incompatibilities with? |
Sorry this was my mistake, I misread the > than sign. I am having trouble installing openmc in the same environment as cadquery but this is not caused by the pyparsing version pin. I don't actually know what is causing my environment errors but have suspicions about the pinned version of vtk in the OCP conda package, but that is another story for me to figure out sometime. This is the environment I'm trying to build if you are super interested any insight is appreciated, but I realize this is a problem for me to solve. conda create --name test python=3.9
conda activate test
conda install -c cadquery -c conda-forge openmc=0.13.0 cadquery=master error message produced
Mamba gives a slightly clearer message
error message produced
I guess that the 7.6.1 version of OCCT might use a new VTK version so it might just be solved as the software stack updates |
I am not able to find a combination of package versions that solves this problem. We can hope that you are correct and 7.6.0 or 7.6.1 will use a non-conflicting version of VTK. |
Thanks for taking a look in to this, these environments are already very impressive collections of packages. I have a two environment solution for now which I can work well with (example of the two env file setup). I can feedback after 7.6.0 / 7.6.1 release in the future |
Following on from #907 can we consider removing the version limit for pyparsing.
I've built a conda package locally for this as well, see this comment on #907