Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed pyparsing limit #1022

Closed
wants to merge 1 commit into from
Closed

removed pyparsing limit #1022

wants to merge 1 commit into from

Conversation

shimwell
Copy link
Contributor

@shimwell shimwell commented Mar 4, 2022

Following on from #907 can we consider removing the version limit for pyparsing.

I've built a conda package locally for this as well, see this comment on #907

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (5147dd8) to head (49d0743).
Report is 374 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1022   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          40       40           
  Lines        9357     9357           
  Branches     1103     1103           
=======================================
  Hits         9008     9008           
  Misses        205      205           
  Partials      144      144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

The constraint on pyparsing is correct.

@shimwell
Copy link
Contributor Author

shimwell commented Mar 4, 2022

Thanks for clarifying that. I guess I was just being hopefull that it could be removed as it causes a few incompatibles in downstream packages so naturally I would be happy to help if I can.
As the PR passed all the tests I'm not really sure what to investigate.
Do let me know if there anything that can be looked into to allow this limit to be removed.

@adam-urbanczyk
Copy link
Member

@shimwell I don't understand what you want say here. Are you claiming that CQ works as-is with pyparsing 2.1.8? What is the incompatibility you are referring to?

@shimwell
Copy link
Contributor Author

shimwell commented Mar 5, 2022

Sorry I got confused with my > and < signs. while trying to figure out why I can't install in my conda environment. Please ignore

@jmwright
Copy link
Member

I guess I was just being hopefull that it could be removed as it causes a few incompatibles in downstream packages

@shimwell Can you give examples of which downstream packages the pinned version causes incompatibilities with?

@shimwell
Copy link
Contributor Author

Sorry this was my mistake,

I misread the > than sign.

I am having trouble installing openmc in the same environment as cadquery but this is not caused by the pyparsing version pin.

I don't actually know what is causing my environment errors but have suspicions about the pinned version of vtk in the OCP conda package, but that is another story for me to figure out sometime. This is the environment I'm trying to build if you are super interested any insight is appreciated, but I realize this is a problem for me to solve.

conda create --name test python=3.9
conda activate test
conda install -c cadquery -c conda-forge openmc=0.13.0 cadquery=master

error message produced

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package _libgcc_mutex conflicts for:
openmc=0.13.0 -> libgcc-ng[version='>=10.3.0'] -> _libgcc_mutex==0.1=conda_forge
python=3.9 -> libgcc-ng[version='>=10.3.0'] -> _libgcc_mutex[version='*|0.1',build='main|conda_forge|main']

Package pypy3.7 conflicts for:
openmc=0.13.0 -> lxml -> pypy3.7[version='7.3.3.*|7.3.4.*|7.3.5.*|7.3.7.*|>=7.3.3|>=7.3.7|>=7.3.5|>=7.3.4']
cadquery=master -> ezdxf -> pypy3.7[version='>=7.3.3|>=7.3.4|>=7.3.5|>=7.3.7']

Package numpy conflicts for:
openmc=0.13.0 -> h5py -> numpy[version='1.10.*|1.11.*|1.12.*|1.13.*|>=1.14.6,<2.0a0|>=1.16.5,<2.0a0|>=1.17.5,<2.0a0|>=1.21.4,<2.0a0|>=1.19.4,<2.0a0|>=1.16.6,<2.0a0|>=1.19.2,<2.0a0|>=1.9.3,<2.0a0|>=1.8|>=1.8,<1.14|>=1.21.2,<2.0a0|>=1.11.3,<2.0a0|>=1.17|>=1.15.4,<2.0a0|>=1.18.4,<2.0a0|>=1.18.1,<2.0a0|>=1.12.1,<2.0a0|>=1.11.*|>=1.9.*|>=1.11|>=1.9|>=1.7|>=1.20.3,<2.0a0|>=1.20.2,<2.0a0|>=1.13.3,<2.0a0|>=1.15.1,<2.0a0']
openmc=0.13.0 -> numpy[version='>=1.18.5,<2.0a0|>=1.19.5,<2.0a0|>=1.21.5,<2.0a0']The following specifications were found to be incompatible with your system:

  - feature:/linux-64::__glibc==2.27=0
  - feature:|@/linux-64::__glibc==2.27=0

Your installed version is: 2.27

Mamba gives a slightly clearer message

conda install -c conda-forge mamba
mamba  install -c cadquery -c conda-forge openmc=0.13.0 cadquery=master

error message produced

Encountered problems while solving:
  - package occt-7.5.3-h7391655_0 requires vtk >=9.0.1,<9.0.2.0a0, but none of the providers can be installed

I guess that the 7.6.1 version of OCCT might use a new VTK version so it might just be solved as the software stack updates

@jmwright
Copy link
Member

jmwright commented Apr 2, 2022

I am not able to find a combination of package versions that solves this problem. We can hope that you are correct and 7.6.0 or 7.6.1 will use a non-conflicting version of VTK.

@shimwell
Copy link
Contributor Author

shimwell commented Apr 2, 2022

Thanks for taking a look in to this, these environments are already very impressive collections of packages. I have a two environment solution for now which I can work well with (example of the two env file setup). I can feedback after 7.6.0 / 7.6.1 release in the future

@shimwell shimwell deleted the patch-1 branch April 4, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants