Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specification of dxf layer names to import. for issue #1051 #1061

Merged
merged 7 commits into from
Jul 17, 2022

Conversation

greyltc
Copy link
Contributor

@greyltc greyltc commented Apr 24, 2022

No description provided.

@greyltc
Copy link
Contributor Author

greyltc commented Apr 24, 2022

That check failure is from black.

Shall I black cadquery in this PR?

black --diff cadquery
...
All done! ✨ 🍰 ✨
10 files would be reformatted, 20 files would be left unchanged.

@adam-urbanczyk
Copy link
Member

That check failure is from black.

Shall I black cadquery in this PR?

black --diff cadquery
...
All done! ✨ 🍰 ✨
10 files would be reformatted, 20 files would be left unchanged.

Please use version specified in https://github.com/CadQuery/cadquery/blob/master/environment.yml

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (f1b8763) to head (47e21a5).
Report is 271 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1061   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          40       40           
  Lines        9648     9672   +24     
  Branches     1272     1280    +8     
=======================================
+ Hits         9293     9317   +24     
  Misses        210      210           
  Partials      145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

@greyltc I fixed the mypy issue. Could you add a test?

@adam-urbanczyk
Copy link
Member

@greyltc do you plan to work on this PR?

@lorenzncode
Copy link
Member

I had made part of these changes 2 months ago but at the time the PR didn't appear ready to review so I shelved them. Anyway it would be good to close the issue (with squash I think ideally).

@adam-urbanczyk adam-urbanczyk self-requested a review July 17, 2022 10:56
@adam-urbanczyk
Copy link
Member

LGTM, thanks @greyltc and @lorenzncode !

@adam-urbanczyk adam-urbanczyk merged commit f3b0b09 into CadQuery:master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants