-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct formatting of cboreHole()
, cskHole()
, and hole()
example code
#1062
Correct formatting of cboreHole()
, cskHole()
, and hole()
example code
#1062
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1062 +/- ##
=======================================
Coverage 96.34% 96.34%
=======================================
Files 40 40
Lines 9533 9533
Branches 1259 1259
=======================================
Hits 9185 9185
Misses 205 205
Partials 143 143
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
6e3a567
to
b22e4f7
Compare
@sethfischer Unless you wrap everything after the assignment = in parentheses, I think you'll still need the line continuation characters. |
b22e4f7
to
9210072
Compare
Amended to escape line continuation character which results in a correctly rendered code block. The same correction was made in Also completed a truncated comment for |
9210072
to
5ade06d
Compare
cboreHole()
, cskHole()
, and hole()
example code
cboreHole()
, cskHole()
, and hole()
example codecboreHole()
, cskHole()
, and hole()
example code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest to format these with black to be consistent with the other examples and also remove Plane.XY()
.
affde13
to
72fe298
Compare
* Format with Black. * Complete truncated comment.
72fe298
to
4bbf8a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest changes it looks good to me, and all the checks pass. Thanks @sethfischer
@lorenzncode Once you confirm that it looks good to you, please feel free to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sethfischer.
Correct formatting of code block.
See https://cadquery.readthedocs.io/en/latest/classreference.html?highlight=cboreHole#cadquery.Workplane.cboreHole which is rendered on a single line with superfluous horizontal whitespace.