Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sketch val, vals methods #1103

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Add Sketch val, vals methods #1103

merged 1 commit into from
Sep 21, 2022
+22 −1

Conversation

lorenzncode
Copy link
Member

Feature - Add Sketch methods #1102.

@codecov
Copy link

codecov bot commented Jun 10, 2022 •
edited
Loading

Codecov Report

Merging #1103 (fd5ec99) into master (a5fadeb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fd5ec99 differs from pull request most recent head 6438737. Consider uploading reports for the commit 6438737 to get more accurate results

@@           Coverage Diff           @@
##           master    #1103   +/-   ##
=======================================
  Coverage   96.34%   96.35%           
=======================================
  Files          40       40           
  Lines        9533     9542    +9     
  Branches     1259     1259           
=======================================
+ Hits         9185     9194    +9     
  Misses        205      205           
  Partials      143      143
Impacted Files Coverage Δ
cadquery/sketch.py 96.34% <100.00%> (+0.03%) ⬆️
tests/test_sketch.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lorenzncode lorenzncode marked this pull request as ready for review July 30, 2022 22:37
@adam-urbanczyk adam-urbanczyk self-requested a review September 20, 2022 05:58
jmwright
jmwright approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lorenzncode !

@jmwright jmwright merged commit 259cc7b into master Sep 21, 2022
@lorenzncode lorenzncode linked an issue Sep 23, 2022 that may be closed by this pull request
Add Sketch val and vals methods #1102
Closed
@lorenzncode lorenzncode deleted the sketch-vals branch September 23, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwright jmwright jmwright approved these changes

@adam-urbanczyk adam-urbanczyk adam-urbanczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Sketch val and vals methods
3 participants
@lorenzncode @jmwright @adam-urbanczyk