Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully closed shelling #394

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Fully closed shelling #394

merged 1 commit into from
Jul 8, 2020

Conversation

adam-urbanczyk
Copy link
Member

This will solve #393 . I was motivated by the discussion on our google group and it is rather small fix. Now one can create hollow models easily:

b = cq.Wokrplane().box(1,1,1).shell(-0.1)

obraz

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #394 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   93.38%   93.44%   +0.05%     
==========================================
  Files          19       19              
  Lines        4976     4989      +13     
  Branches      508      509       +1     
==========================================
+ Hits         4647     4662      +15     
+ Misses        206      205       -1     
+ Partials      123      122       -1     
Impacted Files Coverage Δ
cadquery/cq.py 87.70% <ø> (+0.19%) ⬆️
cadquery/occ_impl/shapes.py 90.24% <100.00%> (+0.10%) ⬆️
tests/test_cadquery.py 98.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9808cce...fc5ddbc. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @adam-urbanczyk thanks!

@adam-urbanczyk
Copy link
Member Author

Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants