Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offset2D implementation #397

Merged
merged 3 commits into from
Jul 12, 2020
Merged

offset2D implementation #397

merged 3 commits into from
Jul 12, 2020

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Jul 10, 2020

Will resolve #208 and #347

  • Implementation
  • Docs

obraz

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #397 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
+ Coverage   93.46%   93.52%   +0.05%     
==========================================
  Files          19       19              
  Lines        5004     5048      +44     
  Branches      514      520       +6     
==========================================
+ Hits         4677     4721      +44     
  Misses        205      205              
  Partials      122      122              
Impacted Files Coverage Δ
cadquery/cq.py 87.93% <100.00%> (+0.14%) ⬆️
cadquery/occ_impl/importers.py 85.89% <100.00%> (-0.85%) ⬇️
cadquery/occ_impl/shapes.py 90.44% <100.00%> (+0.19%) ⬆️
tests/test_cadquery.py 98.96% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacd459...07f69eb. Read the comment docs.

@adam-urbanczyk adam-urbanczyk changed the title offset2D implementation [WIP] offset2D implementation Jul 12, 2020
@adam-urbanczyk adam-urbanczyk requested a review from jmwright July 12, 2020 09:51
@jmwright
Copy link
Member

Ok. I think all discussion items have been resolved. Merging.

@jmwright jmwright merged commit 46fdaf6 into master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: offset curve / tolerance
2 participants