Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DOI to the README #410

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Add a DOI to the README #410

merged 2 commits into from
Jul 22, 2020

Conversation

adam-urbanczyk
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #410 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files          19       19           
  Lines        5139     5139           
  Branches      530      530           
=======================================
  Hits         4808     4808           
  Misses        209      209           
  Partials      122      122           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab2678...6d99592. Read the comment docs.

@adam-urbanczyk
Copy link
Member Author

anything against adding this @jmwright ?

@adam-urbanczyk
Copy link
Member Author

It is a simple README change, so I'm going ahead with the merge.

@adam-urbanczyk adam-urbanczyk merged commit 608ebe6 into master Jul 22, 2020
@jmwright
Copy link
Member

@adam-urbanczyk Sorry, been AFK for a lot of the day. I don't really understand what the purpose of the DOI badge is, and I don't get why it seems to be pointing to CQ-editor.

@adam-urbanczyk
Copy link
Member Author

Yes, fixed in #412 ... Digital Object Identifier can be used to cite CadQuery in scientific publications. So far I found two. They point to the old repo unfortunately.

@jmwright
Copy link
Member

Ah, ok. Got it. Thanks for adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants