Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Intersection = True in shell #411

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Use Intersection = True in shell #411

merged 2 commits into from
Jul 23, 2020

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Jul 22, 2020

Related to google groups discussion. After this modification shelling takes into account intersection between non-adjacent faces:

image

@adam-urbanczyk adam-urbanczyk requested a review from jmwright July 23, 2020 18:01
@codecov
Copy link

codecov bot commented Jul 23, 2020

Codecov Report

Merging #411 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #411   +/-   ##
=======================================
  Coverage   93.55%   93.56%           
=======================================
  Files          19       19           
  Lines        5139     5142    +3     
  Branches      530      530           
=======================================
+ Hits         4808     4811    +3     
  Misses        209      209           
  Partials      122      122           
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 90.67% <ø> (ø)
tests/test_cadquery.py 98.97% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608ebe6...66ea7b8. Read the comment docs.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Merging

@jmwright jmwright merged commit 77b3da3 into master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants