-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXF export (2D) and exporters cleanup #415
Conversation
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 93.56% 93.59% +0.02%
==========================================
Files 19 25 +6
Lines 5147 5291 +144
Branches 530 548 +18
==========================================
+ Hits 4816 4952 +136
- Misses 209 215 +6
- Partials 122 124 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot here so I could have missed some things, but I think it looks good. It's nice to have the exporters broken out and organized rather than all dumped in one (or very few) files. Thanks!
Will resolve #352 , #340, #212, #334 and #360 .
This adds dxf export. Moreover I implemented a new export function and marked exportShape as deprecated:
Now exporting is more user friendly:
exporters.export(obj,'out.step')