-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the choice to not import all dxf layers #442
Conversation
this is especially useful for ignoring layers in drawings containing note text or dimensions
Looks like a good to me, thanks @greyltc @adam-urbanczyk Any objections to merging if all the tests pass? |
Please don't merge yet - I'll have some comments. |
@greyltc Looks like the black lint check failed. That's a new-ish thing that's been added to CI. Let me know if you want an explanation. |
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 93.58% 93.67% +0.09%
==========================================
Files 25 25
Lines 5316 5377 +61
Branches 554 562 +8
==========================================
+ Hits 4975 5037 +62
Misses 215 215
+ Partials 126 125 -1
Continue to review full report at Codecov.
|
OK, I changed the naming slightly (I'd like to eventually add an |
Yeah, I can test! edit: oh, you mean a proper test. |
fix edges/wires mixup remove extra `)` fix var name typo fix lint
I think this is ready to be merged. The travis issues giving the red x there are not related to this pr. |
All green - merging. Thanks @greyltc ! |
this is especially useful for ignoring layers in drawings containing note text or dimensions