Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the choice to not import all dxf layers #442

Merged
merged 5 commits into from
Aug 31, 2020
Merged

add the choice to not import all dxf layers #442

merged 5 commits into from
Aug 31, 2020

Conversation

greyltc
Copy link
Contributor

@greyltc greyltc commented Aug 26, 2020

this is especially useful for ignoring layers in drawings containing note text or dimensions

this is especially useful for ignoring layers in drawings containing note text or dimensions
@jmwright
Copy link
Member

Looks like a good to me, thanks @greyltc

@adam-urbanczyk Any objections to merging if all the tests pass?

@adam-urbanczyk
Copy link
Member

Please don't merge yet - I'll have some comments.

@jmwright
Copy link
Member

@adam-urbanczyk Ok

@greyltc Looks like the black lint check failed. That's a new-ish thing that's been added to CI. Let me know if you want an explanation.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #442 into master will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #442      +/-   ##
==========================================
+ Coverage   93.58%   93.67%   +0.09%     
==========================================
  Files          25       25              
  Lines        5316     5377      +61     
  Branches      554      562       +8     
==========================================
+ Hits         4975     5037      +62     
  Misses        215      215              
+ Partials      126      125       -1     
Impacted Files Coverage Δ
cadquery/occ_impl/importers.py 88.33% <100.00%> (+0.83%) ⬆️
tests/test_importers.py 94.59% <100.00%> (+0.84%) ⬆️
tests/test_selectors.py 100.00% <0.00%> (ø)
cadquery/selectors.py 99.26% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b7e95...e890ff7. Read the comment docs.

@adam-urbanczyk
Copy link
Member

OK, I changed the naming slightly (I'd like to eventually add an include parameter) and excluded layers are not parsed now. Are you willing to add a test for this functionality @greyltc ? If not, I'm OK with merging as-is.

@greyltc
Copy link
Contributor Author

greyltc commented Aug 28, 2020

Yeah, I can test!

edit: oh, you mean a proper test.
I'll give that a shot too.

fix edges/wires mixup

remove extra `)`

fix var name typo

fix lint
@greyltc
Copy link
Contributor Author

greyltc commented Aug 30, 2020

I think this is ready to be merged. The travis issues giving the red x there are not related to this pr.

@adam-urbanczyk
Copy link
Member

All green - merging. Thanks @greyltc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants