Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo. #452

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Fix a typo. #452

merged 2 commits into from
Sep 22, 2020

Conversation

nirvdrum
Copy link
Contributor

No description provided.

@jmwright
Copy link
Member

Thanks for the contribution @nirvdrum !

@jmwright
Copy link
Member

@adam-urbanczyk Black is failing and saying that 13 files need to be reformatted, even though this PR was a single character change. Was the version of black for the Travis build updated recently or something?

@adam-urbanczyk
Copy link
Member

Yes, it needs to be pinned to (see #440) :

- pip install black==19.10b0

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #452 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          25       25           
  Lines        5326     5326           
  Branches      554      554           
=======================================
  Hits         4986     4986           
  Misses        215      215           
  Partials      125      125           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d721d0...0bcd47c. Read the comment docs.

@adam-urbanczyk
Copy link
Member

Thanks @nirvdrum - merging.

@adam-urbanczyk adam-urbanczyk merged commit da07216 into CadQuery:master Sep 22, 2020
adam-urbanczyk added a commit that referenced this pull request Sep 27, 2020
* rarray: bound spacings to greater than 0
This addresses Issue 451

* Fix a typo. (#452)

* Fix a typo.

* Pin black version in travis

Co-authored-by: Adam Urbańczyk <adam-urbanczyk@users.noreply.github.com>

* rarray: bound spacings to greater than 0
This addresses Issue 451

* Added test for rarray error handling

Co-authored-by: Kevin Menard <kevin@nirvdrum.com>
Co-authored-by: Adam Urbańczyk <adam-urbanczyk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants