Fix dxf arc export for some partial circles #455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
I'm not sure if this is the 'right' fix, but some partial circles (specifically, the ones with c_dz.XYZ().Z() < 0) were exporting flipped for me.
The changes are pretty minor, and fixed all the broken arcs on my data. Basically, rotate the arc 180 degrees. I also flipped the start/end and used the is_counterclockwise flag for those arcs.
Broken:
Fixed: