Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nth selector rounding #461

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Conversation

cactrot
Copy link
Contributor

@cactrot cactrot commented Sep 27, 2020

I am almost certain that the number of digits to round to for self.TOLERANCE = 0.0001 should be 4 rather than 10000.

Add the option to specify a path to the font.
Change rounding calculation to produce 4 digits for self.TOLERANCE = 0.0001 rather than 10000.
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #461 into master will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   93.62%   93.45%   -0.18%     
==========================================
  Files          25       25              
  Lines        5332     5864     +532     
  Branches      554      704     +150     
==========================================
+ Hits         4992     5480     +488     
- Misses        215      234      +19     
- Partials      125      150      +25     
Impacted Files Coverage Δ
cadquery/selectors.py 99.09% <100.00%> (ø)
tests/test_cadquery.py 98.98% <0.00%> (+<0.01%) ⬆️
cadquery/cq.py 89.38% <0.00%> (+1.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c819dfc...c07d2a7. Read the comment docs.

@cactrot
Copy link
Contributor Author

cactrot commented Sep 30, 2020

That is weird that most platforms passed, including several versions of windows but not all.

I don't think the test that failed should even depend on DirectionNthSelector

@adam-urbanczyk
Copy link
Member

Let's see of it reproduces.

@cactrot
Copy link
Contributor Author

cactrot commented Sep 30, 2020

The coverage changes it reports are in cq.py and test_cadquery.py. I only edited one line in selectors.py.

https://codecov.io/gh/CadQuery/cadquery/pull/461/changes

It looks like codecov is failing because of other changes happening in the repo.

@adam-urbanczyk
Copy link
Member

Looks good @cactrot , thanks! Codecov sometimes gives false positives.

@adam-urbanczyk adam-urbanczyk merged commit f6bf019 into CadQuery:master Sep 30, 2020
@cactrot cactrot deleted the nth-selector-rounding branch September 30, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants