Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose mode for sweep operations. #496

Merged
merged 9 commits into from
Nov 10, 2020
Merged

Expose mode for sweep operations. #496

merged 9 commits into from
Nov 10, 2020

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Nov 4, 2020

Will partially resolve #97 (not including the law part) and will resolve #498 .

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #496 (280cca2) into master (65f9608) will increase coverage by 0.03%.
The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
+ Coverage   93.70%   93.74%   +0.03%     
==========================================
  Files          30       30              
  Lines        5942     5994      +52     
  Branches      629      636       +7     
==========================================
+ Hits         5568     5619      +51     
  Misses        237      237              
- Partials      137      138       +1     
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 91.23% <96.77%> (+0.12%) ⬆️
cadquery/cq.py 88.45% <100.00%> (+0.11%) ⬆️
tests/test_cadquery.py 99.03% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f9608...280cca2. Read the comment docs.

@adam-urbanczyk adam-urbanczyk changed the title Expose mode for sweep operations [WIP] Expose mode for sweep operations. Nov 10, 2020
@adam-urbanczyk
Copy link
Member Author

I think this PR is ready @jmwright .

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @adam-urbanczyk thanks!

@adam-urbanczyk adam-urbanczyk merged commit 28d6089 into master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workplane.sweep documentation cleanup Implement sweep with fixed normal and auxiliary spine
2 participants