Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples and start testing them #609

Merged
merged 9 commits into from
Jan 31, 2021
Merged

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Jan 30, 2021

Will resolve #601

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #609 (c19a024) into master (68bac66) will decrease coverage by 0.40%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
- Coverage   94.25%   93.84%   -0.41%     
==========================================
  Files          29       31       +2     
  Lines        6366     6447      +81     
  Branches      679      691      +12     
==========================================
+ Hits         6000     6050      +50     
- Misses        227      258      +31     
  Partials      139      139              
Impacted Files Coverage Δ
tests/test_examples.py 89.74% <89.74%> (ø)
cadquery/cq_directive.py 30.95% <0.00%> (ø)
cadquery/cq.py 89.38% <0.00%> (+0.10%) ⬆️
cadquery/cqgi.py 81.40% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bac66...c19a024. Read the comment docs.

@marcus7070
Copy link
Member

I love that you're using the examples as tests now, that's a great improvement.

@adam-urbanczyk
Copy link
Member Author

adam-urbanczyk commented Jan 30, 2021

I'll try to add testing of the examples in the docs too. Should be possible with docutils and a custom implementation of the cq_directive it seems.

https://gist.github.com/mastbaum/2655700

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adam-urbanczyk Looks good, thanks for doing this. All the tests run fine on my local machine as well.

@adam-urbanczyk adam-urbanczyk merged commit 94e0976 into master Jan 31, 2021
@jmwright jmwright deleted the examples-cleanup branch May 24, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples 009, 010, 013 and 024 fail
3 participants