-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples and start testing them #609
Conversation
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
==========================================
- Coverage 94.25% 93.84% -0.41%
==========================================
Files 29 31 +2
Lines 6366 6447 +81
Branches 679 691 +12
==========================================
+ Hits 6000 6050 +50
- Misses 227 258 +31
Partials 139 139
Continue to review full report at Codecov.
|
I love that you're using the examples as tests now, that's a great improvement. |
I'll try to add testing of the examples in the docs too. Should be possible with |
daa7cac
to
c19a024
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adam-urbanczyk Looks good, thanks for doing this. All the tests run fine on my local machine as well.
Will resolve #601