-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning on regex #654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
+ Coverage 93.84% 94.03% +0.19%
==========================================
Files 31 31
Lines 6447 6636 +189
Branches 691 726 +35
==========================================
+ Hits 6050 6240 +190
Misses 258 258
+ Partials 139 138 -1
Continue to review full report at Codecov.
|
These characters now get rendered as a link to something 🤷 in the HTML docs. https://cadquery--654.org.readthedocs.build/en/654/classreference.html#cadquery.selectors.ParallelDirSelector Does pytest still throw warnings if you keep the raw string but add the backslash back in? |
AFAIK |
Sphinx decided it was a link to something
I agree, the best solution would be to tell Sphinx that the pipe symbol is not... whatever it thinks it is (variable substitution? But why does that make a link?). I'm sure there is some way to do that, but sphinx is so complicated and I'll take the easy way out Looks like |
This looks good to me, I can't see any more weird links: https://cadquery--654.org.readthedocs.build/en/654/classreference.html#cadquery.ParallelDirSelector And the pytest warnings (which didn't show up on Azure, but did show up on Travis) are gone. Feel free to try something different if you want to @RubenRubens and I'll have another look at it, or let me know if you want to merge as is. |
All checks are green. Shall I merge? |
@jmwright, I'd just wait for @RubenRubens. If they are feeling like a deep dive into the sphinx internals, there might be a way to do this better. If they don't feel like a deep dive then this will do, I'm certainly not volunteering to figure out why sphinx thinks |
Great! Let's just merge this then. |
Thanks @RubenRubens ! |
This simple fix removes a warning in
pytest
.