Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Workplane.findFace #679

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Deprecate Workplane.findFace #679

merged 1 commit into from
Mar 10, 2021

Conversation

marcus7070
Copy link
Member

Will close #665.

@codecov
Copy link

codecov bot commented Mar 8, 2021 •
edited
Loading

Codecov Report

Merging #679 (156b7a2) into master (0325474) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #679   +/-   ##
=======================================
  Coverage   94.19%   94.20%           
=======================================
  Files          31       31           
  Lines        6689     6690    +1     
  Branches      725      725           
=======================================
+ Hits         6301     6302    +1     
  Misses        253      253           
  Partials      135      135
Impacted Files Coverage Δ
cadquery/cq.py 90.81% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0325474...156b7a2. Read the comment docs.

@marcus7070 marcus7070 requested a review from jmwright March 8, 2021 08:06
jmwright
jmwright approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @marcus7070

@jmwright jmwright merged commit ceea71d into CadQuery:master Mar 10, 2021
@marcus7070 marcus7070 deleted the deprecate-findFace branch March 10, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam-urbanczyk adam-urbanczyk adam-urbanczyk approved these changes

@jmwright jmwright jmwright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Workplane.findFace?
3 participants
@marcus7070 @jmwright @adam-urbanczyk