Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2D fillet chamfer #683

Merged
merged 7 commits into from
Mar 11, 2021
Merged

2D fillet chamfer #683

merged 7 commits into from
Mar 11, 2021

Conversation

adam-urbanczyk
Copy link
Member

Will resolve #348

@adam-urbanczyk
Copy link
Member Author

Open question: do we want to expose those functions in the fluent API?

@codecov
Copy link

codecov bot commented Mar 10, 2021 •
edited
Loading

Codecov Report

Merging #683 (6d764ed) into master (48deb19) will increase coverage by 0.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
+ Coverage   94.21%   94.93%   +0.72%     
==========================================
  Files          31       31              
  Lines        6702     8410    +1708     
  Branches      726      997     +271     
==========================================
+ Hits         6314     7984    +1670     
- Misses        253      264      +11     
- Partials      135      162      +27
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.22% <100.00%> (+0.27%) ⬆️
tests/test_cadquery.py 99.35% <100.00%> (+0.24%) ⬆️
cadquery/cq.py 92.62% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48deb19...6d764ed. Read the comment docs.

jmwright
jmwright approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adam-urbanczyk

@marcus7070
Remove duplicate test method
1a61242 
Looks like git got confused and re-added testCompSolid
marcus7070
marcus7070 requested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@marcus7070 marcus7070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the online OCCT docs are down right now, otherwise I would help out more with that chamfer2D stuff.

@marcus7070 marcus7070 merged commit 5542816 into master Mar 11, 2021
@marcus7070
Copy link
Member

Thanks @adam-urbanczyk, this stuff looks great! That Shape._entitiesFrom method looks very powerful, I hope we get to do some other things with it!

Open question: do we want to expose those functions in the fluent API?

Yeah, that would be great. I can think of a few options on how we do it in a fluent way, I'll start a new issue to discuss.

@marcus7070 marcus7070 deleted the 2D-fillet-chamfer branch March 12, 2021 03:45
@marcus7070 marcus7070 mentioned this pull request Mar 12, 2021
Closed
marcus7070 added a commit to marcus7070/cadquery that referenced this pull request Mar 14, 2021
@adam-urbanczyk @marcus7070
2D fillet chamfer (CadQuery#683)
e25e465 
* Implement 2D chamfers and fillets

* Implement 2D chamfer/fillet tests

Co-authored-by: Marcus Boyd <mwb@geosol.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmwright jmwright jmwright approved these changes

@marcus7070 marcus7070 marcus7070 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose 2D fillet and 2D chamfer
3 participants
@adam-urbanczyk @marcus7070 @jmwright