Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cqgi.rst with a helpful example #711

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

DarthPJB
Copy link
Contributor

@DarthPJB DarthPJB commented Apr 3, 2021

After about an hour of googling and picking through the documentation (and cq-editor source) I made a script to automate export into STL format.

I've submitted this as a pull-request in the belief it may benefit others.

On a personal note; a big thank you to everyone on this project; cadquery is the future!

@DarthPJB DarthPJB changed the title Update cqgi.rst Update cqgi.rst with a helpful example Apr 3, 2021
@codecov
Copy link

codecov bot commented Apr 3, 2021

Codecov Report

Merging #711 (677e84a) into master (7546866) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

❗ Current head 677e84a differs from pull request most recent head adb9caa. Consider uploading reports for the commit adb9caa to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #711      +/-   ##
==========================================
- Coverage   94.54%   94.50%   -0.04%     
==========================================
  Files          32       32              
  Lines        7071     7078       +7     
  Branches      766      768       +2     
==========================================
+ Hits         6685     6689       +4     
- Misses        253      255       +2     
- Partials      133      134       +1     
Impacted Files Coverage Δ
cadquery/occ_impl/shapes.py 92.37% <60.00%> (-0.16%) ⬇️
tests/test_cadquery.py 99.17% <100.00%> (+<0.01%) ⬆️
tests/test_workplanes.py 99.30% <0.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7546866...adb9caa. Read the comment docs.

@adam-urbanczyk
Copy link
Member

Thanks! May I ask what is wrong with this example form the docs: https://cadquery.readthedocs.io/en/latest/importexport.html#exporting-stl ?

@DarthPJB
Copy link
Contributor Author

DarthPJB commented Apr 4, 2021

Thanks! May I ask what is wrong with this example form the docs: https://cadquery.readthedocs.io/en/latest/importexport.html#exporting-stl ?

That example doesn't use the CQGI ~ which is fine if you want to export as part of the CAD-code itself; this example is for a user wishing to batch-process existing cadquery-files without modification.

Quite esoteric perhaps, but useful I hope.

Copy link
Member

@marcus7070 marcus7070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @DarthPJB. It's great to see the CQGI area of the docs getting some attention.

@marcus7070 marcus7070 merged commit a71a93e into CadQuery:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants