Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workplane.rect: test and document negative lengths #774

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

marcus7070
Copy link
Member

Will close #773.

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #774 (c6e56b0) into master (05e42a7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files          32       32           
  Lines        7256     7265    +9     
  Branches      789      789           
=======================================
+ Hits         6868     6877    +9     
  Misses        255      255           
  Partials      133      133           
Impacted Files Coverage Δ
cadquery/cq.py 91.32% <ø> (ø)
tests/test_cadquery.py 99.18% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e42a7...c6e56b0. Read the comment docs.

@marcus7070 marcus7070 marked this pull request as ready for review May 24, 2021 11:27
Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcus7070 !

@adam-urbanczyk
Copy link
Member

Thanks @marcus7070 - merging.

@adam-urbanczyk adam-urbanczyk merged commit 7b1a99c into master Jun 1, 2021
@marcus7070 marcus7070 deleted the marcus7070/rect-neg branch June 1, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow rect to have negative lengths to reverse direction (much like extrude)
3 participants