-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented cq.Vector.projectToLine() method #835
Conversation
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 32 32
Lines 7654 7663 +9
Branches 815 815
=======================================
+ Hits 7339 7348 +9
Misses 186 186
Partials 129 129
Continue to review full report at Codecov.
|
'*' operator for cq.Vector should now allow being used for scaledVector = 4 * cq.Vector(1, 1, 1) in addition to the already working scaledVector = cq.Vector(1, 1, 1) * 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @A-G-D
Added an implementation for the said method, as well as a unit test.