Fix inconsistent 2D and 3D spellings #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmwright
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
Thanks @revolter
@marcus7070 We can merge this if you want, but I would like to keep one of these PRs that's failing on the mypy check open so that we can use it to make sure we have fixed the mypy/OCP-stubs issue.
|
My original diagnosis of OCP-stubs being the issue looks to be mistaken, and we have other ways of testing that we have fixed the issue. I'm going to go ahead and merge this. Thanks @revolter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, the regex that I used:
\b[23][^*nr]d\b