Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sketch rarray bug when used with push #994

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

lorenzncode
Copy link
Member

An extra translation is applied when rarray is used with push. Compare with/without push (easy to see with push([(0,0)]).

The form of the parray return statement is correct. I would have liked to add a similar test for parray anyway but did not finish testing it yet.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #994 (8d4c3ea) into master (ed8e62c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #994   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          40       40           
  Lines        9292     9293    +1     
  Branches     1109     1109           
=======================================
+ Hits         8937     8938    +1     
  Misses        208      208           
  Partials      147      147           
Impacted Files Coverage Δ
cadquery/sketch.py 96.25% <ø> (ø)
tests/test_sketch.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed8e62c...8d4c3ea. Read the comment docs.

@adam-urbanczyk
Copy link
Member

Thanks @lorenzncode, shall I merge?

@lorenzncode
Copy link
Member Author

Yes, please merge this rarray fix. I don't have any other changes to make to this PR.

@adam-urbanczyk adam-urbanczyk merged commit 23de5cc into CadQuery:master Feb 15, 2022
@lorenzncode lorenzncode deleted the fix-rarray branch February 16, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants