Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 Format Support #552

Draft
wants to merge 49 commits into
base: dev
Choose a base branch
from
Draft

v4 Format Support #552

wants to merge 49 commits into from

Conversation

XAce1337manX
Copy link
Collaborator

Features:

  • Can edit v4 maps - Mainly for compatibility with official editor
  • Saving with incompatible data in format will prompt a warning
  • Additions to Song Info screen to support new fields
    • Vanilla:
      • Mappers, lighters, and shared lightshow fields
      • Environment selection per diff
    • Custom:
      • Read support for custom characteristics
      • Stub wip menu for new SongCore features (lets users know the feature exists)
      • Small UX improvements to pop up menus (rewording and closing)
SongCore custom characteristic display Environment Removal moved into Custom Properties menu
image image

(If any one wants to offer suggestions to the menu, feel free)

Brief overview of changes:

  • BeatSaberSong replaced with BaseInfo. Reading to and writing from this is handled in V2Info and V4Info
    • A majority of changes will be just changing this reference
    • V4 classes, as with V2 and V3, just handle IO
  • New maps are created with v4 info as it gives access to some new metadata fields and still supports difficulties of any version.
  • New difficulties are still created in v3 as CustomJSONData does not have a specification for v4. For now, v4 custom properties will display with v3 json in editor and will not persist on save

Lots of things to deal with. I expect to find more bugs when this gets merged.

Nothing else works :D
Was how it previously behaved
*Except for Fx Events
Lightshow to be done later
@XAce1337manX XAce1337manX marked this pull request as draft December 10, 2024 13:49
@XAce1337manX
Copy link
Collaborator Author

Well. 1.40 just dropped with a bunch of map new features.

@Caeden117
Copy link
Owner

I don’t think the 1.40 additions to v4 blocks the PR. If you feel its ready for a dev merge, go for it, but I do totally understand if you want to ensure the latest features get added beforehand

@XAce1337manX
Copy link
Collaborator Author

Plans for this PR is probably:

  • Merge after stable push - dev is in a stable state atm so I'm going to see if there's any bug fixes I can push to that before
  • Add new fields to this PR so CM doesn't yeet them
    • No support in editor for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants