Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.21 no chickens from eggs #525

Closed
Coding-Kiwi opened this issue Jun 18, 2024 · 3 comments
Closed

1.21 no chickens from eggs #525

Coding-Kiwi opened this issue Jun 18, 2024 · 3 comments
Labels
A-vanilla-parity Area: Vanilla Parity F-has-workaround Flag: There is a workaround available P-high Priority: High R-pending-release Resolution: Pending release S-fixed Status: Fixed T-bug Type: Bug

Comments

@Coding-Kiwi
Copy link

Coding-Kiwi commented Jun 18, 2024

Version Information

lithium-fabric-mc1.21-0.12.5

Expected Behavior

Chicken should spawn from thrown eggs

Actual Behavior

No chicken spawn, or very very very rarely one spawns (see video)

Reproduction Steps

Throw eggs

Other Information

  • I tested it with and without lithium, without lithium the chicken spawn normally
  • I think it has something to do with an entity limit / mob cap? but it is not quite transparent what the limit is set to and what influences it

https://imgur.com/a/6Mc5x0r

@Coding-Kiwi Coding-Kiwi added the T-bug Type: Bug label Jun 18, 2024
2No2Name added a commit that referenced this issue Jun 18, 2024
@2No2Name 2No2Name added P-high Priority: High A-vanilla-parity Area: Vanilla Parity S-confirmed Status: Confirmed R-pending-release Resolution: Pending release S-needs-testing Status: Needs testing to verify resolution labels Jun 18, 2024
@2No2Name
Copy link
Member

Thanks a lot for the report.
Vanilla's check for chicken spawning changed, includes collisions in a special way now. But lithium's new optimization for that was broken.

From my testing the above commit fixes the issue.

@2No2Name 2No2Name added the F-has-workaround Flag: There is a workaround available label Jun 18, 2024
@2No2Name
Copy link
Member

2No2Name commented Jun 18, 2024

Workaround: Add line to config/lithium.properties file:
mixin.minimal_nonvanilla.collisions.empty_space=false

@Coding-Kiwi
Copy link
Author

Thank you for the quick analysis and workaround, can confirm mixin.minimal_nonvanilla.collisions.empty_space=false works

@2No2Name 2No2Name added S-fixed Status: Fixed and removed S-needs-testing Status: Needs testing to verify resolution S-confirmed Status: Confirmed labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vanilla-parity Area: Vanilla Parity F-has-workaround Flag: There is a workaround available P-high Priority: High R-pending-release Resolution: Pending release S-fixed Status: Fixed T-bug Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants