Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconistancy of clipped minecart collisions with vanilla #143

Closed
Alugia7 opened this issue Sep 22, 2020 · 2 comments
Closed

Inconistancy of clipped minecart collisions with vanilla #143

Alugia7 opened this issue Sep 22, 2020 · 2 comments
Assignees
@2No2Name
Labels
S-confirmed Status: Confirmed T-bug Type: Bug

Comments

@Alugia7
Copy link

Alugia7 commented Sep 22, 2020

Expected Behavior

See video:
https://www.youtube.com/watch?v=j38Zq2efmi8
The minecart clipped in this setup stays clipped into the cauldron and solid block when the top piston is moved

Actual Behavior

See video:
https://www.youtube.com/watch?v=IRpEAyyxW3A
The minecart does not properly clip into the solid block and instead falls through it.

Reproduction Steps

  1. Perform clip shown in video
  2. Power the top piston which would move the cauldron
  3. Minecart isnt clipped into solid block with lithium, which is inconsistent with vanilla
@Alugia7 Alugia7 added the T-bug Type: Bug label Sep 22, 2020
@2No2Name 2No2Name self-assigned this Sep 22, 2020
@2No2Name 2No2Name added the S-confirmed Status: Confirmed label Sep 22, 2020
@2No2Name
Copy link
Member

This is probably caused by the custom voxel shape implementation for voxelshapes that are 1/8th aligned not returning the point positions when combineAndSimplify is called.

2No2Name added a commit that referenced this issue Sep 23, 2020
@2No2Name
fix: VoxelShapeAlignedCuboid.getPointPositions different from vanilla…
8365a88 
… causing combineAndSimplify creating a slightly different shape for cauldrons

new: CuboidVoxelSet used in VoxelShapeAlignedCuboid to simulate BitSetVoxelSet behavior

related issue: Inconistancy of clipped minecart collisions with vanilla #143
@jellysquid3
Copy link
Member

Fixed in Lithium 0.5.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2No2Name 2No2Name

Labels
S-confirmed Status: Confirmed T-bug Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jellysquid3 @Alugia7 @2No2Name