Apply thread-local cache to InitLayer and MergingLayer #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskarth
approved these changes
Sep 5, 2020
|
Looking at the code now. Are you saying the vanilla code has race conditions? |
2No2Name
approved these changes
Sep 10, 2020
src/main/java/me/jellysquid/mods/lithium/common/world/layer/CachedLocalLayerFactory.java
Outdated
Show resolved
Hide resolved
|
I don't remember exactly how we ended up with these cache sizes- I recall there was the consideration of how many threads there are, but also the reduced memory overhead with this implementation in comparison to vanilla. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were only applying this to
ParentedLayer, which would eliminate the majority of potential race conditions. This would make any race condition issue practically impossible in a vanilla context, but when adding more threads, it becomes much more likely to occur through the alternativeInitLayerandMergingLayer, which were missed by accident in the original PR.