Integrate GDPR banner add-on #473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cookie-consent/ with little modification for better button colors management
…e only technical cookies - buttons with uniform color to respect GDPR rules
|
Thanks for the PR ⭐ Unfortunately I'll take a long time to be able to process this PR since the style does not fit into the theme. I'll try to figure out a design for this, but no ETA is given (just started the second semester, kinda busy right now). |
|
No problem. GDPR integration is more complicated than expected so I need
to do some other changes whitout destroy your setup.
Il Dom 30 Gen 2022, 09:57 Jimmy Cai ***@***.***> ha scritto:
… Thanks for the PR ⭐
Unfortunately *I'll take a long time* to be able to process this PR since
the style does not fit into the theme. I'll try to figure out a design for
this, but no ETA is given (just started the second semester, kinda busy
right now).
—
Reply to this email directly, view it on GitHub
<#473 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWPAR4KQBNWVDZKPX2J5AO3UYT4ONANCNFSM5M6AFXKA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: GDPR prompt #412 implementation proposal
following https://hugocodex.org/add-ons/cookie-consent/ with little modification for better button colors management