Nav bar account icon dropdown #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ability to navigate to Profile page of signed in user - Ability to logout
- Yarn format
jacquelineyin
commented
Jul 9, 2020
jacquelineyin
commented
Jul 9, 2020
| @@ -32,20 +33,27 @@ const GoogleLogoutBtn = ({ | |||
| unsetUser(); | |||
| logoutSuccess("Successfully logged out!"); | |||
| closeModal(); | |||
| return response; | |||
There was a problem hiding this comment.
Notes: There was a bug from a previous commit whereby if a user logs in with a gmail account through the normal login (not the google one), they are given the google logout, which then didn't work. The issue persists in this commit. (Copied straight from my commit description because I'm lazy xD). Not sure how to fix this, so I'll pass it back to you
Not sure if the response is supposed to do anything. I logged it and it gives "Undefined", but to get rid of the lint warning, I just returned the response xD.
There was a problem hiding this comment.
yeah its a useless response. Could even remove it.
…r-AccountIcon-Dropdown
…of params compared to BE Addition: Changed username so that it's the first half of the email address
…riate args - Fixed bug where it returned normal logout button even when it was a google account
…use/tradeforce into NavBar-AccountIcon-Dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Changes in this commit:
-- Profile: redirects to profile page
-- Logout: logs user out and redirects them to homepage
Notes:
There was a bug from a previous commit whereby if a user logs in with a gmail account through the normal login (not the google one), they are given the google logout, which then didn't work. The issue persists in this commit
Material ui has a bug: where locking the scrollbar will introduce whitespace (see here). Worked around it by disabling scrollbar lock, but this allows the menu dropdown to float when user scrolls