Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #652, #683 #685

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

jtraulle
Copy link
Contributor

@jtraulle jtraulle commented Apr 20, 2018

Fixes #652, #683

@codecov-io
Copy link

Codecov Report

Merging #685 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #685      +/-   ##
============================================
+ Coverage      80.37%   80.4%   +0.02%     
- Complexity       543     544       +1     
============================================
  Files             52      52              
  Lines           1692    1694       +2     
============================================
+ Hits            1360    1362       +2     
  Misses           332     332
Impacted Files Coverage Δ Complexity Δ
src/Model/Behavior/RegisterBehavior.php 97.05% <ø> (-0.35%) 22 <0> (-3)
src/Controller/Traits/UserValidationTrait.php 84.44% <100%> (ø) 14 <0> (ø) ⬇️
src/Controller/Traits/PasswordManagementTrait.php 76.25% <100%> (+0.3%) 22 <0> (ø) ⬇️
src/Model/Behavior/PasswordBehavior.php 100% <100%> (ø) 22 <4> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cf90d...77565e1. Read the comment docs.

@jtraulle jtraulle changed the title Fixes CakeDC/users#652 and CakeDC/users#683 Fixes #652, #683 Apr 20, 2018
@ajibarra
Copy link
Member

Thanks for your contribution!

@ajibarra ajibarra merged commit 1b1bcce into CakeDC:develop Apr 24, 2018
ravage84 added a commit to ravage84/users that referenced this pull request Apr 13, 2021
ajibarra pushed a commit to ravage84/users that referenced this pull request Jan 10, 2025
ajibarra pushed a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants