Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlashHelper incompatible with CakePHP 4 #10

Open
1 of 3 tasks
asgraf opened this issue Dec 15, 2022 · 2 comments
Open
1 of 3 tasks

FlashHelper incompatible with CakePHP 4 #10

asgraf opened this issue Dec 15, 2022 · 2 comments
Assignees
@Erwane

Comments

@asgraf
Copy link
Contributor

asgraf commented Dec 15, 2022

This is a (multiple allowed):

  • bug

  • enhancement

  • question

  • PHP Version: 8.1

  • CakePHP Version: 4.4.3

  • Plugin Version/Branch: v4.x-dev

What you did

Tried to load FlashHelper

What happened

Fatal error: Declaration of Bootstrap\View\Helper\FlashHelper::render($key = 'flash', array $options = []) must be compatible with Cake\View\Helper\FlashHelper::render(string $key = 'flash', array $options = []): ?string in /application/vendor/holt59/cakephp4-bootstrap-helpers/src/View/Helper/FlashHelper.php on line 33

What you expected to happen

No Fatal Errors
@asgraf asgraf mentioned this issue Dec 15, 2022
Closed
@Erwane Erwane self-assigned this Dec 15, 2022
@Erwane Erwane mentioned this issue Dec 15, 2022
Merged
@Erwane
Copy link
Collaborator

Erwane commented Dec 15, 2022

could you try this version please before i tag it ?
composer require holt59/cakephp4-bootstrap-helpers:dev-fix-10-declaration
Thanks

@asgraf
Copy link
Contributor Author

asgraf commented Dec 15, 2022

I tried it and it fixed the issue for me

Erwane added a commit that referenced this issue Dec 16, 2022
@Erwane
Merge pull request #12 from CakePHP-Bootstrap/fix-10-declaration
fc2a8a6 
Fix #10 declaration
Erwane added a commit that referenced this issue Dec 16, 2022
@Erwane
Merge pull request #13 from CakePHP-Bootstrap/fix-10-declaration-bs3
8d23776 
Fix #10 declarations for bootstrap3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erwane Erwane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Erwane @asgraf