-
Notifications
You must be signed in to change notification settings - Fork 142
Separate plots #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Separate plots #293
Conversation
c5d93e0 to
b34af15
Compare
|
The bug was that there was a clause for overlaying the pdf plot on top of the log-log ESD. When I examined the code, it looked like that code was intended to run unconditionally whenever anything gets plotted, because it was interwoven with the clause for computing |
b34af15 to
f7193c2
Compare
… check in valid_params
…pected number of plots
f7193c2 to
53d8de9
Compare
Addresses #292
This PR does the following:
plotargument toWeightWatcher.analyze()and other entry points to take either a boolean argument, which is replaced with the list of ALL plots ifTrue, else an empty list; or to take a list of valid plot constants from the list abovevalid_params()to ensure the plot argument only has allowed constants in itparams[PLOT]list orplotargument, whichever argument is passed to the function where plotting takes place.safedir.The following tests are currently passing, or else have the same failures as in the
masterbranch:The following tests have been skipped due to runtime: