Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dependency cycles to fix eslint errors #17

Merged
merged 10 commits into from
May 15, 2023

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Oct 20, 2022

Closes Caleydo/cohort#693

Requires Caleydo/coral#50

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

Screenshots

Additional notes for the reviewer(s)


Thanks for creating this pull request 🤗

@thinkh thinkh added release: major PR merge results in a new major version type: refactor Refactor the current implementation labels Oct 20, 2022
@oltionchampari oltionchampari changed the title Remove yarn.lock Fix eslint errors Mar 8, 2023
@oltionchampari oltionchampari marked this pull request as ready for review March 13, 2023 09:21
@oltionchampari oltionchampari requested a review from keckelt as a code owner March 13, 2023 09:21
@thinkh thinkh self-assigned this May 15, 2023
@thinkh thinkh changed the title Fix eslint errors refactor: remove dependency cycles to fix eslint errors May 15, 2023
@oltionchampari oltionchampari self-requested a review May 15, 2023 13:39
oltionchampari
oltionchampari previously approved these changes May 15, 2023
@thinkh thinkh merged commit 5bafd45 into develop May 15, 2023
@thinkh thinkh mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: major PR merge results in a new major version type: refactor Refactor the current implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants