Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip detail view chooser if only one detail view is available #357

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Skip detail view chooser if only one detail view is available #357

merged 3 commits into from
Apr 14, 2022

Conversation

oltionchampari
Copy link
Contributor

Closes datavisyn/ordino_bayer_indications#90

Summary

  • Added logic to skip detail view chooser if only one detail view is available
  • Added some border between the viewWrappers when the detail view chooser is hidden

Screenshot

grafik

@oltionchampari oltionchampari added type: feature New feature or request release: minor PR merge results in a new minor version labels Feb 11, 2022
@oltionchampari oltionchampari requested review from thinkh, a user and rumersdorfer February 11, 2022 10:17
@oltionchampari oltionchampari assigned thinkh and ghost Feb 11, 2022
rumersdorfer
rumersdorfer reviewed Feb 17, 2022
View reviewed changes
Copy link
Contributor

@rumersdorfer rumersdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected in Ordino Indications/EINS 👍

thinkh
thinkh requested changes Mar 21, 2022
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the functionality. Code-wise it looks fine. Please add a minor comment to the @extends. Thanks.

@oltionchampari oltionchampari requested a review from thinkh April 13, 2022 09:44
thinkh
thinkh approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@thinkh thinkh merged commit a5bfad8 into develop Apr 14, 2022
@thinkh thinkh deleted the och/single-view-available branch April 14, 2022 12:32
@oltionchampari oltionchampari mentioned this pull request Apr 20, 2022
Merged
This was referenced Apr 27, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumersdorfer rumersdorfer rumersdorfer left review comments

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oltionchampari @thinkh @rumersdorfer