Fix app crash when replacing views with object ref from graph.findOrAddObject()
#405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #402 See GitHub issue for in-depth analysis and testing results.
thinkh
added
type: bug
thinkh
changed the title
graph.findOrAddObject() when replacing viewsgraph.findOrAddObject()
|
@rumersdorfer I've tested this PR with Ordino Public and it worked as before. However, it would be good to have a second opinion and testing cycle for Ordino. Please test Ordino Daily against a local Ordino instance with this PR. Check out the following branches in your local Ordino workspace:
Test if all actions regarding opening, closing and replacing a second view are still working as expected and if old provenance tracks (i.e., exported from Ordino Daily and imported locally) still result in the same state. Please post your result here and if everything works submit a successful review. Let me know if you have further questions. Thanks. |
oltionchampari
approved these changes
Jun 21, 2022
|
@thinkh @oltionchampari Bug is fixed in Indications. 👍 |
|
Bug is also fixed in Ordino. 👍 |
Merged
dvvanessastoiber
added a commit
that referenced
this pull request
Jul 28, 2023
## What's Changed ### Features * CLUE support for URL query parameter + refactor public session link by @thinkh in #419 * Replace jQuery scrollTo plugin with custom implementation by @thinkh in #425 * Improve typings for new session functions by @thinkh in #427 * Allow tour card description to include html by @oltionchampari in #432 ### Bugfixes * Fix wrong view name in replace action title by using `ViewWrapper` context by @thinkh in #406 * Fix app crash when replacing views with object ref from `graph.findOrAddObject()` by @thinkh in #405 * Add vertical padding to tour cards and use full height teaser image by @dvmichaelpeterseil in #430 ### Chore * Remove `nav.mainNavi` styles by @thinkh in #415 * Improve Cypress setup and use Cypress commands.js by @dvvanessastoiber in #354 * Add Visyn Scripts by @datavisyn-bot in #421 * Add dist/ folder by @dvtschachinger in #423 * Migration to visyn_core by @oltionchampari in #429 * React 18 Migration by @dvmoritzschoefl in #431 ## New Contributors * @datavisyn-bot made their first contribution in #421 * @dvtschachinger made their first contribution in #423 * @dvmichaelpeterseil made their first contribution in #430 * @dvmoritzschoefl made their first contribution in #431 **Full Changelog**: v13.0.1...v14.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #402
Developer Checklist (Definition of Done)
next-version: minor) to this PR following semverSummary of changes
graph.findOrAddObject()fixes the object refScreenshots