Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deep links from tours page into tours #151

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix: deep links from tours page into tours #151

merged 1 commit into from
Apr 11, 2023

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Apr 11, 2023

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • We forgot to switch the deep links to tours from # to ?

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@thinkh thinkh added type: bug Something isn't working release: patch PR merge results in a new patch version labels Apr 11, 2023
@oltionchampari oltionchampari merged commit 06ff7b6 into develop Apr 11, 2023
@oltionchampari oltionchampari deleted the thinkh/fix-deep-links-into-tours branch April 11, 2023 10:47
@thinkh thinkh mentioned this pull request Jul 28, 2023
Merged
dvvanessastoiber added a commit that referenced this pull request Jul 28, 2023
@dvvanessastoiber
Release 14.0.0 (#154)
2b71e3e 
## What's Changed

### Features

* Use URL search query for CLUE and rewrite hash parameters by @thinkh
in #142
* Add release notes for Ordino release v10.1 by @thinkh in
#147
* Add release notes for Ordino release v11.0 by @thinkh in
#153

### Bugfixes

* Fix deep links from tours page into tours by @thinkh in
#151

### Chore

* Improve Cypress setup and structure by @dvvanessastoiber in
#141
* Cypress testing by @dvvanessastoiber in
#133
* Add Visyn Scripts by @datavisyn-bot in
#144
* Migration to visyn_core by @oltionchampari in
#150
* React 18 Migration by @dvmoritzschoefl in
#152

## New Contributors
* @datavisyn-bot made their first contribution in
#144
* @dvmoritzschoefl made their first contribution in
#152

**Full Changelog**:
v13.1.1...v14.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oltionchampari oltionchampari oltionchampari approved these changes

Assignees

@oltionchampari oltionchampari

Labels
release: patch PR merge results in a new patch version type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkh @oltionchampari