Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Fix parameter desc typings #159

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix parameter desc typings #159

merged 1 commit into from
Sep 14, 2021

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Sep 13, 2021

Summary

  • Switch from IFormSelectDesc to IFormElementDesc because we are using other form elements than selects
  • Afterwards CircleCI should be green for tdp_publicdb again.

@thinkh
Fix parameter desc typings
c9c1703 
Switch from `IFormSelectDesc` to `IFormElementDesc` because we are using other form elements than selects
@thinkh thinkh added the type: bug Something isn't working label Sep 13, 2021
@thinkh thinkh mentioned this pull request Sep 13, 2021
Merged
dvvanessastoiber
dvvanessastoiber approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@dvvanessastoiber dvvanessastoiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests, thank you for the changes! 👍

@thinkh thinkh merged commit ae0b9f1 into develop Sep 14, 2021
@thinkh thinkh deleted the thinkh/fix-parameter-desc-typings branch September 14, 2021 11:19
@dvvanessastoiber dvvanessastoiber mentioned this pull request Oct 7, 2021
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvvanessastoiber dvvanessastoiber dvvanessastoiber approved these changes

Assignees

@dvvanessastoiber dvvanessastoiber

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkh @dvvanessastoiber