Use OpenGL 3.3 Core Profile

[clayjohn]

This removes enough deprecated functionality to make the Core Profile display correctly for editor usage.

The core profile changes were just made for Windows as I don't have a linux test environment right now.

You need to run in single window mode because creating separate windows still does not work.

But we now have all the basics for editor usage.

[github-actions]

Download the artifacts for this pull request:

• linux-editor.zip
• linux-template-mono.zip

[Whimfoome]

Can confirm that it works on Linux with Wayland, but I don't know what Core Profile display really means

Got some opengl errors
drivers/opengl/shader_opengl.cpp:90 - Condition "!version" is true. Returning: false drivers/opengl/shader_opengl.cpp:90 - Condition "!version" is true. Returning: false

Also, not really related to this PR, but does the renderer switcher really need to be in the top right corner at all times? You change that option maybe once or twice for the whole project, I don't think we need it visible all the time.

[Calinou]

Also, not really related to this PR, but does the renderer switcher really need to be in the top right corner at all times? You change that option maybe once or twice for the whole project, I don't think we need it visible all the time.

The dropdown is useful for engine maintainers, as it lets us know which renderer is being used whenever an editor screenshot is posted somewhere 🙂

This makes troubleshooting easier.

[clayjohn]

@Whimfoome Thank you for checking, but X11 is still set to Compatibility Profile. Once @Calinou merges this, he can update X11 to use core profile in the parent branch.

Those shader errors you see are unrelated to this PR. They come from 3D features which haven't been re-enabled yet.

[clayjohn]

@Calinou this is ready for merging whenever you are available.

[Calinou]

@Calinou this is ready for merging whenever you are available.

I tried to run it on X11 with this change:

diff --git a/platform/linuxbsd/gl_manager_x11.cpp b/platform/linuxbsd/gl_manager_x11.cpp
index 5928ff3147..1b1c55a550 100644
--- a/platform/linuxbsd/gl_manager_x11.cpp
+++ b/platform/linuxbsd/gl_manager_x11.cpp
@@ -175,12 +175,10 @@ Error GLManager_X11::_create_context(GLDisplay &gl_display) {
 
 	switch (context_type) {
 		case GLES_3_0_COMPATIBLE: {
-			// FIXME: Use `GLX_CONTEXT_CORE_PROFILE_BIT_ARB` instead of compatibility profile
-			// once deprecated API usages are fixed.
 			static int context_attribs[] = {
 				GLX_CONTEXT_MAJOR_VERSION_ARB, 3,
 				GLX_CONTEXT_MINOR_VERSION_ARB, 3,
-				GLX_CONTEXT_PROFILE_MASK_ARB, GLX_CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB,
+				GLX_CONTEXT_PROFILE_MASK_ARB, GLX_CONTEXT_CORE_PROFILE_BIT_ARB,
 				GLX_CONTEXT_FLAGS_ARB, GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB /*|GLX_CONTEXT_DEBUG_BIT_ARB*/,
 				None
 			};

However, I'm getting a black screen with a white quadrant on the project manager with --rendering-driver opengl --single-window:

Godot Engine v4.0.dev.custom_build.77dfa4f7f - https://godotengine.org
creating display driver : x11
creating rendering driver : opengl
rendering_driver opengl
ERROR: BUG: Unreferenced static string to 0: interface_added
   at: unref (core/string/string_name.cpp:116)
ERROR: BUG: Unreferenced static string to 0: interface_added
   at: unref (core/string/string_name.cpp:116)
rendering_driver opengl
window_create window id 0
WARNING: Property not found: rendering/quality/2d/use_nvidia_rect_flicker_workaround
     at: _get (core/config/project_settings.cpp:245)
WARNING: Property not found: rendering/quality/shading/force_lambert_over_burley
     at: _get (core/config/project_settings.cpp:245)
WARNING: Property not found: rendering/quality/shading/force_blinn_over_ggx
     at: _get (core/config/project_settings.cpp:245)
OpenGL Renderer: NVIDIA GeForce GTX 1080/PCIe/SSE2
ERROR: Condition "!props.has(p_prop)" is true.
   at: set_custom_property_info (core/config/project_settings.cpp:971)
ERROR: Condition "!props.has(p_prop)" is true.
   at: set_custom_property_info (core/config/project_settings.cpp:971)

... [shader code printed out] ...

ERROR: CanvasShaderOpenGL: Vertex shader compilation failed:
0(18) : error C7555: 'attribute' is deprecated, use 'in/out' instead
0(25) : error C7555: 'attribute' is deprecated, use 'in/out' instead
0(26) : error C7555: 'attribute' is deprecated, use 'in/out' instead
0(63) : error C7555: 'varying' is deprecated, use 'in/out' instead
0(64) : error C7555: 'varying' is deprecated, use 'in/out' instead

   at: _display_error_with_code (drivers/opengl/shader_opengl.cpp:129)
ERROR: Method/function failed. Returning: __null
   at: get_current_version (drivers/opengl/shader_opengl.cpp:300)
ERROR: Condition "!version" is true. Returning: false
   at: bind (drivers/opengl/shader_opengl.cpp:90)
ERROR: Condition "!version" is true. Returning: -1
   at: _get_uniform (./drivers/opengl/shader_opengl.h:263)

[clayjohn]

Ah nice to see. I guess my drivers are a little too forgiving. Windows drivers often are.

I can update the PR with the fix this evening.

[clayjohn]

@Calinou this should be ready to go now. I tested on my laptop which has a stricter driver.

[Calinou]

Tested on Linux (GeForce GTX 1080), it works.

Thanks!