Checkstyle and github workflow action #20
Conversation
Signed-off-by: Rick Poleshuck <RickPoleshuck@gmail.com>
Signed-off-by: Rick Poleshuck <RickPoleshuck@gmail.com>
|
There's a lot going on in this PR Rick, so it's hard to review - can you summarize what's going on in the comments? I put my specific questions into my code review here. |
| with: | ||
| java-version: '11' | ||
| distribution: 'adopt' | ||
| - run: mvn --batch-mode --update-snapshots -Pprod verify |
There was a problem hiding this comment.
I'm new to Github Actions - does this actually deploy somewhere?
| <property name="message" value="No printing to console, use a logger."/> | ||
| </module> | ||
| </module> | ||
| </module> |
There was a problem hiding this comment.
I'm not familiar with this particular linter, but it should be good to add.
| <suppressions> | ||
| <!-- io.swagger package is generated, don't run checks --> | ||
| <suppress files="[\\/]io[\\/]swagger[\\/]" checks="[a-zA-Z0-9]*"/> | ||
| </suppressions> |
| return qr; | ||
| } | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
What's the intent of these changes?
| public QueryResult<Client> getAllClientsOfAttorney(String attorneyId) { | ||
| QueryResult<Client> qr = db.query(new QueryBuilder(eq("attorneyId", attorneyId)).build(), Client.class); | ||
| return qr; | ||
| } | ||
| } |
There was a problem hiding this comment.
What's the intent of these changes?
| String healthURL = (uriInfo.getAbsolutePath() + "/v1/health").replaceAll("(?<!http:)\\/\\/", "/"); | ||
| String exampleURL = (uriInfo.getAbsolutePath() + "/v1/example").replaceAll("(?<!http:)\\/\\/", "/"); | ||
| return Response.ok("{\"health\":\"" + healthURL + "\",\"example\":\"" + exampleURL + "\"}").build(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this just a simple formatting change then?
|
Right now I am recommending a rewrite of the Aggregator. If that is
approved, this PR is moot. Let's circle back after tomorrow's meeting.
…On Wed, 2021-08-25 at 04:37 -0700, Ann Marie Fred wrote:
There's a lot going on in this PR Rick, so it's hard to review - can
you either break it up into a couple of PRs or summarize what's going
on in the comments?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
There are 3 parts to this PR.
|
|
👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed. |
sforsyth089
modified the milestones:
Sprint 4: 11/8-11/19,
Sprint 5 11/22/21 to 12/3/21
|
👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed. |
upkarlidder
modified the milestones:
Sprint 5 11/22/21 to 12/3/21,
Sprint 2 01/17/22 to 01/28/22
sforsyth089
modified the milestones:
Sprint 2 01/17/22 to 01/28/22,
Sprint 3 01/31/22 to 02/11/22
|
@kossiefu who should be the reviewer here from MS? |
|
@RickPoleshuck, @upkarlidder do we still want to move forward with this change? It aligns with what the ms_cohort haas been working on. We can build on top of it. |
sforsyth089
modified the milestones:
Sprint 4 02/14/22 to 02/25/22,
Sprint 5 02/26/22 to 03/11/22
No description provided.