-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externalize pipeline architecture #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lize all stages in main memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the functionalities discusses in #15
WARNING: this PR introduces major changes to almost every class in the framework, so it will likely break all existing forks.
The changes are:
PipelineEngine
.PipelineEngine
are used to execute every operation in the main query engine, which removes the strong coupling torxjs
.RxjsPipeline
is a subclass ofPipelineEngine
which implements the pipeline operations usingrxjs
. It corresponds to the engine behaviour before this PR.RxjsPipeline
is used as the default pipeline implementation.VectorPiepline
is a subclass ofPipelineEngine
which follows the vectorization paradigm: all intermediate results are materialized in main memory. This pipeline impl. is more efficient CPU-wise, but consume more memory.PipelineEngine
.