-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goodness-of-Fit Scoring, QOL, and Functional Updates #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove mandatory creation of new fig and ax in Multiple_Curves.plot() to allow for superclass Curve's plot() function to handle plotting according to documentation
This reverts commit f5e4873.
Remove mandatory creation of new fig and ax in Multiple_Curves.plot() to make functionality consistent with documentation
Prevent unphysical rho calculations due to low overburden pressure for a thin surface layer
As per scipy.signal.butter, "If the transfer function form [b, a] is requested, numerical problems can occur since the conversion between roots and the polynomial coefficients is a numerically sensitive operation"
Even though the dummy curves are not simulation significant, since the ggmax and damping parameters are calibrated separately, allows for the proper curves to be created by their corresponding calibrated parameters to avoid triggering a ValueError related to unrealistic damping curves created from the parameters calibrated for the ggmax curves
…ol verbosity settings Adds option to capture ValueErrors when running batch simulation, so a single failed simulation won't halt the entire batch process. In addition, adjusts the verbose settings to capture output if verbose is false, so multiple parallel processes won't all be printing the nonlinear simulation progress bar over each other.
Handles situations in which the optimizer searches very large or small values of the 'a' parameter, which may result in a RuntimeWarning due to the exponential in the expression
Class file and file to hold helper functions
Add gof scores
Fxia minor updates
Added option to use the forkserver context for spawning subprocesses using the multiprocessing module.
Added forkserver example usage
Updated documentation of new code to meet contribution requirements. Updated tests to reflect minor changes in code. Updated formatting to meet tox requirements.
Fixed filepath error, updated to match recent changes
Added relevant files to docs/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Content:
Functional Changes:
Addressing Errors:
QOL: