Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]add mluop cholesky #1018
base: master
Are you sure you want to change the base?
[WIP]add mluop cholesky #1018
Changes from all commits
5735b5b
123d886
09fa51c
1b25d9c
0da4788
7f745a0
c86edf7
c2cda94
7b2d908
1d3fce8
a432bac
23be9c4
16b4220
0707bfb
70dd01b
b1fbaed
ffc19ca
abffac6
810c19d
600fbd8
e7361af
ba492c2
c84b719
1c7a410
18e299e
9285fb3
3632c31
f863840
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
删除这种调试的代码,或者改成用mlu_ops中VLOG的宏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已改为VLOG宏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有更新吗?代码上看还是printf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的8,16,2000建议修改成有含义的变量
另外这里建议增加注释说明为啥有两个分支?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 magic number建议修改成有含义的变量,提升可读性