-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md to add windows docs #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mondus a couple of small tweaks and a question about the install command.
I've forwarded it to the user and will see how she gets on - using cmake --build
rather than make
may be important!
…S/fortran-pytorch-lib into windows-build-instructions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Just a couple of questions
just added a note about loading intel compilers. If @mondus is happy then I think we can merge it in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Windows. All good. Happy to approve. One minor suggestion comment to add a link to Intel guide on setvars.
Co-authored-by: Paul Richmond <p.richmond@sheffield.ac.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all who contributed here, I'm now happy to go ahead so will merge in a moment.
Changes have been made as appropriate.
Adds details of
CMAKE_PREFIX_PATH