IMC Pull Request #105
Open
IMC Pull Request #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… within same timestep
…e particle dungeons
…now supplied to mat_class automatically, and deltaT obtained from materialMenu_mod
…ently enegry-weights are unchanged during the collision
… an entirely new processor
… particle by SURF_TOL whenever grid cell is crossed
…rce of info for energy grid
…n energy, plus other MG changes
… to count 0s in timestep. Would be nice to figure out a neat way to change radiationConstant as well for running marshak wave
…empts from dungeon_class
… numerical issues, added a lot of comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMC and ISMC both working well for grey case and for multi frequency, with several new benchmarks added. New geometry class to easily generate large grids. Redid all of the hybrid tracking bits and bobs that I presented at M&C2023, should now be a lot easier to follow and also more efficient. In a lot of cases surface tracking within the new geometry class will be fast enough that there isn't much time to be saved anyway, but definitely has some interesting possibilities especially if using on top of a CSG geometry. When merging with the main branch I discovered that you've created materialSource_class.f90... I had a similar source with the same name, for now I've renamed my original one to imcMaterialSource_class.f90. At some point it might be possible to combine these in a fairly general way, although my one is a bit more complex so you might want to keep it IMC-specific. The main differences between the two are that I am sourcing particles in each material with numbers proportional to the total energy emitted, and if the geometry is geometryGrid_class then this is done within the bounds of each material rather than rejection sampling within the whole geometry which would be too slow for some of the benchmarks.