Update compiler versions in Docker container #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the containers are already there. But we have this single failure in the |
valeriaRaffuzzi
force-pushed
the
update_docker_compilers
branch
from
c8801ee to
e06542e
Compare
Mikolaj-A-Kowalski
approved these changes
Dec 23, 2024
Comment on lines
+213
to
+214
| ! Associate pointer to pass tests in debug mode | ||
| p % pRNG => pRNG |
There was a problem hiding this comment.
Do we know why it was unhappy?
Was it because we provide the pointer later to a function with a non-pointer dummy argument (if it is the case thank you GCC!)
There was a problem hiding this comment.
I don't think so. The error I was getting was because the particle gets passed to a few functions (something like mgDatabase % getTrackingXS -> mgDatabase % getTotalXS -> mgMaterial % getTotalXS) and eventually p % pRNG is an argument, and the problem was that this is a pointer and it was unassigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade compiler versions consistently with the upgrade in the Docker container.
NOTE: The tests should fail until the PR to upgrade the Docker container is accepted.