Nth collision tally #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This all looks good.
My main comment is that, I think, for practical applications, we are not often interested in the 15th collided neutrons, for example, but neutrons which have undergone some range of collisions - maybe the uncollided and the more than once collided for example. Otherwise this would require knowing how many collisions a neutron will undergo to estimate. Are there any convenient ways in which we can tally these? Would this need a new integer map type? Is this new map type desirable?
ChasingNeutrons
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
I think there should be a check on collisionN here too in the isEqual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a 1D tally map for the number of collisions that a particle went through.
A collision counter is added to the particle. This is incremented in collisionProcessor_inter, after a collision happened and before reportOutCollision. When a particle is generated by fission, the counter has to be set to zero for the new source particles.