Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean all text files to make them more UNIX #73

Merged

Conversation

Mikolaj-A-Kowalski
Copy link
Collaborator

Basically applies large number of changes that does not change anything but just cleans up the files which do not conform to typical convention used in programming. That is files that:

  • Have any trailing whitespace at the end of the line
  • Contain DOS-style line endings: CRLF
  • Do not terminate with the new line feed

Sadly this is a very large change and may cause a significant number of annoying conflicts :-(
I don't know if we wish to merge it now. Or if we want to include scripts that may make this clean-up (more or less) automated in the future.

@valeriaRaffuzzi
Copy link
Member

Other than the conflicts coming from the recent PRs that we just merged, I don't think that this PR will break anything.

In the future probably having a script that automates this clean up would be great, maybe open an issue about it? Otherwise I think we can just resolve conflicts and merge without problems.

Copy link
Member

@valeriaRaffuzzi valeriaRaffuzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

I'm sure conflicts will not be too painful honestly. After those are solved I think this is good to go.

@valeriaRaffuzzi valeriaRaffuzzi merged commit 1bb17bc into CambridgeNuclear:main Sep 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants