Move reading of id, origin and rotation to universe_inter
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid code repeat when setting up the basic data common to all universes (id, origin and rotation).
valeriaRaffuzzi
requested changes
Sep 4, 2023
|
|
||
| ! Make shure root does not contain neither origin nor rotation | ||
| ! Make sure root does not contain neither origin nor rotation | ||
| if (dict % isPresent('origin')) then |
There was a problem hiding this comment.
dict % isPresent('origin')
is repeated twice in line 92 and 95
There was a problem hiding this comment.
Yikes!!!
It has been there for long.... Good thing nobody was rotating root universes... 😨
There was a problem hiding this comment.
Should be resolved now.
Due to a copy-paste error keyword 'origin' was used to check if 'rotation' is provided in the input dictionary.
valeriaRaffuzzi
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the code repeated in each universe subclass that sets up the properties of the base
universeclass to a separate, common function.This allows to avoid code repeat and will make the extension (to e.g. time-dependent transformations) easier.