fix: fix set-output #249
Merged
fix: fix set-output #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
2 times, most recently
from
2f7d342
to
ed717ba
Compare
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
from
ed717ba
to
54e1e39
Compare
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
7 times, most recently
from
08c2caa
to
8d4a34b
Compare
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
2 times, most recently
from
4c0b788
to
f38513a
Compare
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
from
f38513a
to
3bdabfa
Compare
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
from
3bdabfa
to
43a35ab
Compare
| process.env['INPUT_URL'] = 'ftp://>invalid|url<' | ||
| process.env['INPUT_URL'] = 'abc' |
There was a problem hiding this comment.
unsure why, but tests with an ftp url just hanged indefinetively....
package.json
Outdated
| "pack": "ncc build", | ||
| "single-file": "ncc build", |
There was a problem hiding this comment.
yarn pack is a built in command, so I renamed it to avoid conflicts
| @@ -22,11 +22,14 @@ export function graphqlPayloadFor( | |||
| ): string { | |||
| const query = minify(rawQuery) | |||
| const minifiedVariables = minify(rawVariables) | |||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment | |||
There was a problem hiding this comment.
I'll open follow up issues for all of these manual overrides. At the moment I just want to make sure the release pipeline works as expected
Comment on lines
-187
to
+188
| it('should handle missing input gracefully', async () => { | ||
| it.skipWindows('should handle missing input gracefully', async () => { |
There was a problem hiding this comment.
see #251 as to why we had to skip on Windows
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
from
0fa7a7a
to
e9c8d47
Compare
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
3 times, most recently
from
5e49c0d
to
bfc88eb
Compare
CamiloGarciaLaRotta
force-pushed
the
fix/set-output
branch
from
bfc88eb
to
2b3c595
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Attempt to fix #247
If you look at the
Checkstab, we should see noset-outputdeprecation warning.How
Quite a bunch of changes:
npm run allscript which generated a newdist/index.js(file used by GH Actions itself) was not working. The fix was a mix of:cc @rvanderlinden for visibility