Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames method name in ConditionsMatcher #815

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Renames method name in ConditionsMatcher #815

merged 1 commit into from
Mar 5, 2023

Conversation

pietervisser
Copy link
Contributor

Renames ConditionsMatcher#matches_hash_conditions to matches_hash_conditions? to better communicate that it returns a boolean, like the other matches_xx? methods.

coorasse
coorasse approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@coorasse coorasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coorasse coorasse merged commit eaddc37 into CanCanCommunity:develop Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coorasse coorasse coorasse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pietervisser @coorasse